[FIXED JENKINS-42371] - Call disconnect() on HttpURLConnection object #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release the network resource(s) held by the underlying connection(s?): - during retry attempts - after obtaining the JNLP connection arguments
oleg-nenashev
approved these changes
Feb 28, 2017
There was a problem hiding this comment.
Looks good 👍 . CC @stephenc
I should definitely revive the static analysis flows in the codebase.
|
As we discussed in IRC, it is a backporting candidate |
stephenc
approved these changes
Feb 28, 2017
|
Related issue: https://issues.jenkins-ci.org/browse/JENKINS-42371 |
oleg-nenashev
changed the title
oleg-nenashev
added a commit
that referenced
this pull request
Mar 3, 2017
oleg-nenashev
added a commit
to oleg-nenashev/jenkins
that referenced
this pull request
Mar 3, 2017
Fixed issues: * [JENKINS-42371](https://issues.jenkins-ci.org/browse/JENKINS-42371) - Properly close the `URLConnection` when parsing connection arguments from the JNLP file. It was causing a descriptor leak in the case of multiple connection attempts. ([PR jenkinsci#152](jenkinsci/remoting#152))
oleg-nenashev
added a commit
to jenkinsci/jenkins
that referenced
this pull request
Mar 8, 2017
* [FIXES JENKINS-42371] - Update remoting to 3.6 Fixed issues: * [JENKINS-42371](https://issues.jenkins-ci.org/browse/JENKINS-42371) - Properly close the `URLConnection` when parsing connection arguments from the JNLP file. It was causing a descriptor leak in the case of multiple connection attempts. ([PR #152](jenkinsci/remoting#152)) * Remoting 3.6 has been burned
olivergondza
pushed a commit
to jenkinsci/jenkins
that referenced
this pull request
Mar 13, 2017
* [FIXES JENKINS-42371] - Update remoting to 3.6 Fixed issues: * [JENKINS-42371](https://issues.jenkins-ci.org/browse/JENKINS-42371) - Properly close the `URLConnection` when parsing connection arguments from the JNLP file. It was causing a descriptor leak in the case of multiple connection attempts. ([PR #152](jenkinsci/remoting#152)) * Remoting 3.6 has been burned (cherry picked from commit b6e4fb4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release the network resource(s) held by the underlying connection(s?):